Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI/Vulnerabilities: Fixed-In section is not clear what it means, should not hide its content #393

Closed
mikemccracken opened this issue Nov 2, 2023 · 4 comments
Assignees
Labels
bug Something isn't working ui ZOT web-based UI related tasks

Comments

@mikemccracken
Copy link

zot version

v1.4.3

Describe the bug

when viewing the list of vulns for a given image, there is a button "fixed in", which was not clear at first sight.
It could be reworded to something like "Tags where this cve has been fixed:" or something even better.

Also, if feasible, this should not require a click to see if there are any such results. at a minimum it could say "tags where it's fixed (3):", or just display the list.

To reproduce

No response

Expected behavior

No response

Screenshots

image

Additional context

No response

@mikemccracken mikemccracken added the bug Something isn't working label Nov 2, 2023
@andaaron andaaron added the ui ZOT web-based UI related tasks label Nov 9, 2023
@andaaron andaaron transferred this issue from project-zot/zot Nov 27, 2023
@andaaron
Copy link
Contributor

andaaron commented Dec 6, 2023

Some context.

"The fixed in" button makes a separate request to return results. That request will need the process the results for every image in the same repo.

If the results are cached, this should not be a big performance hit, but if they are not, that will involve a lot of work to be done on backend side to get information the user may not be interested in when accessing this tab.

@mikemccracken
Copy link
Author

OK, that makes sense. I still think it'd be a nice improvement, but it isn't critical. If it's possible to display it inline when it's cached and just show a link when it's not, that'd be fine too. (assuming the cache lives for a while and someone else is likely to see it)

FWIW, from my perspective I would always be interested in this info when looking at the vulns for a tag.

I'd also still like to suggest changing the wording, or at least giving a help tooltip explaining it.

@andaaron
Copy link
Contributor

Hi @mikemccracken, do we still need this change after the refactoring of the CVE tiles?

@mikemccracken
Copy link
Author

Hi, no the new design resolves this. Thanks!

@andaaron andaaron closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@andaaron andaaron closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui ZOT web-based UI related tasks
Projects
None yet
Development

No branches or pull requests

4 participants