update test_arrangements #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
May 30, 2019
MartinBasti
reviewed
May 31, 2019
stickler-ci
reviewed
Jun 3, 2019
chmeliik
reviewed
Jun 4, 2019
chmeliik
reviewed
Jun 4, 2019
chmeliik
reviewed
Jun 4, 2019
chmeliik
reviewed
Jun 4, 2019
mlangsdorf
force-pushed
the
obsb7503
branch
2 times, most recently
from
6fe8d46
to
90c51fe
Compare
rcerven
reviewed
Jun 5, 2019
rcerven
reviewed
Jun 5, 2019
|
Please remove this bin file from PR |
fixes osbs-7503 Move the tests from arrangements 1-5 that are still valid into arrangement 6, and update them as necessary so that they pass with the current code. Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
fixes osbs-7503 remove the dead code for testing arrangements 1-5 Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
part of osbs-7496 move render_tag_from_container_yaml, test_prod_is_from_scratch, render_tag_from_container_yaml_contains_bad_tag, and test_adjust_for_triggers_base_builds out of test_buildrequest and into test_buildrequestv2 or test_arrangements, as appropriate. Part of deprecating and removing build_request v1.
rcerven
approved these changes
Jun 6, 2019
|
So can we now remove old arrangement json files and prod build? |
|
Sure, but that's not this PR. |
|
ok, thanks |
|
@MartinBasti @mlangsdorf I'm pretty sure removing prod jsons would require at least changes to |
MartinBasti
approved these changes
Jun 10, 2019
|
not updating release note, just tests cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses osbs-7503
Some of the tests for arrangement 1-5 are still valid but are no longer run because arrangements 1-5 are not valid. Move those tests into arrangement 6, updating them as necessary.