Skip to content
This repository has been archived by the owner on Jul 29, 2018. It is now read-only.

Info log messages should be used when certificates get copied to host #5

Closed
navidshaikh opened this issue Feb 9, 2016 · 10 comments
Closed
Assignees
Milestone

Comments

@navidshaikh
Copy link
Collaborator

From @hferentschik on January 28, 2016 12:3

Currently everything adbinfo does is in silent mode which makes it hard to a user to understand what's even going on. For example it would be nice to get some info logging that client certificate files are getting copied to the host and to where.

Atm the output of vagrant adbinfo needs to also be evaluated by a shell, so this might be hard to do. This is one more reason to make certificate generation and re-configuration of the Docker daemon part of the provisioning.

Also the README as well as the built-in help should be more descriptive.

Copied from original issue: projectatomic/vagrant-adbinfo#79

@navidshaikh
Copy link
Collaborator Author

From @LalatenduMohanty on January 28, 2016 12:20

@hferentschik +1 . As per discussion with @navidshaikh , we will make make certificate generation and re-configuration of the Docker daemon part of provisioning

@navidshaikh
Copy link
Collaborator Author

From @hferentschik on January 28, 2016 13:18

As per discussion with @navidshaikh , we will make make certificate generation and re-configuration of the Docker daemon part of provisioning

Awesome. This will allow to write out some info messages to the user during this provisioning which will help the user to better understand what's going on.

@navidshaikh
Copy link
Collaborator Author

From @hferentschik on January 28, 2016 13:18

Could you add label focus:devex ;-)

@bexelbie
Copy link
Contributor

The fix referenced below is for the "face" of this issue - notify the user when a certificate is copied to their workstation.

The fix for certificate regeneration is, as mentioned above, a provisioner or something related and is a separate issue.

@hferentschik
Copy link
Contributor

Not sure how valuable this message is, while we still do this certificate creation as part of the command. For me this goes hand in hand with moving the actual certificate creation into provisioning

@hferentschik
Copy link
Contributor

:-(

@navidshaikh
Copy link
Collaborator Author

@hferentschik : The provisioner we discussed is being worked upon, copying certs is part of command execution, and the PR addresses same.

@navidshaikh
Copy link
Collaborator Author

renamed the issue #21 : "Generate TLS certs during provisioning"

@hferentschik
Copy link
Contributor

The provisioner we discussed is being worked upon

Awesome

copying certs is part of command execution, and the PR addresses same.

Sure, I get that. What I am saying is that while the certificates are copied during the command execution, they might add confusion. Also we have to write it as a "comment" using '#'. I as thinking about a Vagrant info message.

@bexelbie
Copy link
Contributor

@heferentschik line 93 of the PR outputs a comment. What do you mean by vagrant info message?

I believe this fixes the notification of the copy. We hope to have a POC of proper first boot cert generation by mid-next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants