Skip to content

Commit

Permalink
Unpin the version of capybara (#1677)
Browse files Browse the repository at this point in the history
This was originally set in
0ddf30a

but this blocks us from using Rails 5.1
  • Loading branch information
jcoyne authored and cbeer committed Apr 24, 2017
1 parent 5b8023d commit ea4d74c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion blacklight.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "rspec-rails", "~> 3.5"
s.add_development_dependency "rspec-its"
s.add_development_dependency "rspec-collection_matchers", ">= 1.0"
s.add_development_dependency "capybara", '~> 2.6.0'
s.add_development_dependency "capybara", '~> 2.6'
s.add_development_dependency "poltergeist"
s.add_development_dependency 'engine_cart', '~> 1.0'
s.add_development_dependency "equivalent-xml"
Expand Down
29 changes: 15 additions & 14 deletions spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
# frozen_string_literal: true

describe Blacklight::HashAsHiddenFieldsHelperBehavior do
before(:each) do
@hash = {:q => "query", :search_field => "search_field", :per_page=>10, :page=>5, :extra_arbitrary_key=>"arbitrary_value", :f=> {:field1 => ["a", "b"], :field2=> ["z"]}}
let(:params) do
{ q: "query",
search_field: "search_field",
per_page: 10,
page: 5,
extra_arbitrary_key: "arbitrary_value",
f: { field1: %w(a b), field2: ["z"] } }
end
let(:generated) { helper.render_hash_as_hidden_fields(params) }

it "converts a hash with nested complex data to Rails-style hidden form fields" do

generated = helper.render_hash_as_hidden_fields(@hash)

expect(generated).to have_selector("input[type='hidden'][name='q'][value='query']")
expect(generated).to have_selector("input[type='hidden'][name='per_page'][value='10']")
expect(generated).to have_selector("input[type='hidden'][name='page'][value='5']")
expect(generated).to have_selector("input[type='hidden'][name='extra_arbitrary_key'][value='arbitrary_value']")
expect(generated).to have_selector("input[type='hidden'][name='f[field2][]'][value='z']")
expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='a']")
expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='b']")

expect(generated).to have_selector("input[type='hidden'][name='q'][value='query']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='per_page'][value='10']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='page'][value='5']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='extra_arbitrary_key'][value='arbitrary_value']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='f[field2][]'][value='z']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='a']", visible: false)
expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='b']", visible: false)
end

end

0 comments on commit ea4d74c

Please sign in to comment.