Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a fielded search for a search field with clause params builds invalid JSON queries #3048

Closed
barmintor opened this issue Jun 22, 2023 · 0 comments · Fixed by #3057
Closed

Removing a fielded search for a search field with clause params builds invalid JSON queries #3048

barmintor opened this issue Jun 22, 2023 · 0 comments · Fixed by #3057
Labels
Bug

Comments

@barmintor
Copy link
Contributor

Error: Blacklight::Solr::SearchBuilderBehavior#add_search_field_with_json_query_parameters builds invalid JSON queries when a search field has been specified but all constraint values have been removed
Steps to reproduce:

  1. Configure clause_params for the title search field
  2. Search in the title field
  3. Remove the constraint by clicking the 'X' in the results page

Remediation:
The method should either return early if search_state.query_param is nil, or default to a blank string if it is falsy
@barmintor barmintor added the Bug label Jun 22, 2023
barmintor added a commit to barmintor/blacklight that referenced this issue Jun 22, 2023
@barmintor
do not add nil query value clauses to json query (projectblacklight#3048
9b8598c 
)
barmintor added a commit to barmintor/blacklight that referenced this issue Jul 6, 2023
@barmintor
do not add nil query value clauses to json query (projectblacklight#3048
8c876fc 
)
@barmintor barmintor mentioned this issue Jul 6, 2023
Merged
barmintor added a commit to barmintor/blacklight that referenced this issue Jul 7, 2023
@barmintor
do not add nil query value clauses to json query (projectblacklight#3048
4b0669a 
)
barmintor added a commit to barmintor/blacklight that referenced this issue Jul 7, 2023
@barmintor
do not add nil query value clauses to json query (projectblacklight#3048
615d2ef 
)
@sandbergja sandbergja mentioned this issue Aug 3, 2023
Closed
@maxkadel maxkadel mentioned this issue Sep 7, 2023
Closed
maxkadel pushed a commit to maxkadel/blacklight that referenced this issue Sep 8, 2023
@barmintor @maxkadel
do not add nil query value clauses to json query (projectblacklight#3048
259f6d9 
)
@maxkadel maxkadel mentioned this issue Sep 8, 2023
Merged
barmintor added a commit to barmintor/blacklight that referenced this issue Sep 8, 2023
@barmintor
do not add nil query value clauses to json query (projectblacklight#3048
8378b23 
)
jcoyne added a commit that referenced this issue Sep 11, 2023
@jcoyne
Merge pull request #3057 from barmintor/issue-3048-nil-json-param
3e0cc07 
do not add nil query value clauses to json query (#3048)
sandbergja pushed a commit that referenced this issue Sep 11, 2023
@maxkadel @barmintor
I3048 backport nil json param (#3074)
9a4da40 
* do not add nil query value clauses to json query (#3048)

* Add test for empty query with JSON DSL

* Update to use options for feature specs

---------

Co-authored-by: Benjamin Armintor <armintor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not add nil query value clauses to json query (#3048) barmintor/blacklight
1 participant
@barmintor