do not add nil query value clauses to json query (#3048) #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmintor
force-pushed
the
issue-3048-nil-json-param
branch
2 times, most recently
from
4b0669a
to
615d2ef
Compare
This was referenced Sep 7, 2023
Closed
barmintor
force-pushed
the
issue-3048-nil-json-param
branch
from
615d2ef
to
06dc871
Compare
|
rebased on main and pulled in @maxkadel's test (🦖 ) |
|
Added a commit to addess rubocop updates: |
|
Added a commit to address kwargs change in selenium-webdriver (#3076 ) |
jcoyne
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3048
This refines the built-in advanced search features and better supports modern Solr