Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facet "More>>" link shows up for every facet #958

Closed
cbeer opened this issue Jul 25, 2014 · 1 comment · Fixed by #961
Closed

Facet "More>>" link shows up for every facet #958

cbeer opened this issue Jul 25, 2014 · 1 comment · Fixed by #961
Milestone
5.5.3

Comments

@cbeer
Copy link
Member

cbeer commented Jul 25, 2014

It looks like the "more >>" link is showing up for every facet, even those configured without limit: true or limit: n, maybe as a result of this commit f1dc4b3#diff-88f22cc932dd87bb5b46d8440e7f0784R85?

@jcoyne, any idea?
@cbeer cbeer mentioned this issue Jul 25, 2014
Closed
@jcoyne
Copy link
Member

jcoyne commented Jul 31, 2014

I will be working on this early next week.

@mejackreed mejackreed mentioned this issue Jul 31, 2014
Closed
@awead awead mentioned this issue Aug 1, 2014
Merged
jcoyne added a commit that referenced this issue Aug 4, 2014
@jcoyne
Don't show "more" link for every facet.
f7a48e8 
Show "more" link when the facet limit is set to `true` or an integer
value. Fixes #958
@jcoyne jcoyne mentioned this issue Aug 4, 2014
Merged
@jkeck jkeck closed this as completed in #961 Aug 6, 2014
@mejackreed mejackreed added this to the 5.5.3 milestone Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.3
3 participants
@jcoyne @cbeer @mejackreed