made words break when too long in facet labels #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bmaddy this looks good to me. |
|
@cbeer, did you have thoughts on this PR? If it looks good it would be nice to get it merged so we can get it into sufia (I was told you were the person to contact about that). |
jcoyne
added a commit
that referenced
this pull request
Aug 7, 2014
made words break when too long in facet labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a word is too long in the facet labels, it causes its container to explode into the main content when the browser window is narrow. This PR fixes that by allowing the browser to break some words onto the next line.
In the images below I've placed a long word in the label that starts with G.
Before
Chrome
Note the totals that have escaped
After
Chrome
Once Chrome supports the
hyphendirective, we should get a nice hyphen for words that are broken (this hyphen isn't included when copying the text).Safari
Firefox
IE9
The label has a box around it because it was selected in the dom tree; it won't show up normally.
