Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of out-of-the-box navbar-toggle element on an inverse navbar #1011

Merged
merged 1 commit into from
Nov 12, 2014

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Nov 11, 2014

focus + hover:
screen shot 2014-11-11 at 3 32 11 pm

active:
screen shot 2014-11-11 at 3 31 55 pm

Fixes #895? @mejackreed ?

@jcoyne
Copy link
Member

jcoyne commented Nov 12, 2014

Looks good!

@mejackreed
Copy link
Contributor

I'm not sure if this necessarily solves the tab order issue in IE. I kind boot up windows tomorrow and check into it. 👍 but let me check on #895

@cbeer
Copy link
Member Author

cbeer commented Nov 12, 2014

It doesn't change the tab order, just makes the toggle a little more visible. I'm assuming (for better or worse) bootstrap has a decent reason to push the order they do.

@mejackreed
Copy link
Contributor

👍 ok then... good to :shipit: ?

@cbeer
Copy link
Member Author

cbeer commented Nov 12, 2014

:shipit:

mejackreed added a commit that referenced this pull request Nov 12, 2014
Improve styling of out-of-the-box navbar-toggle element on an inverse navbar
@mejackreed mejackreed merged commit 7d4a004 into master Nov 12, 2014
@mejackreed mejackreed deleted the navbar-toggle branch November 12, 2014 01:02
@cbeer cbeer modified the milestone: 5.8.0 Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE navigation keyboard accessibility issue at 200% zoom
3 participants