Release 5.9 backports #1083
Merged
Release 5.9 backports #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same constraints
…not deep-dup'ed to preserve the original classes Fixes #1061 If those class names are dup'ed, methods that expect ActiveModel::Naming don't behave correctly
|
Yes, good idea. |
| alias_method :inheritable_copy, :deep_dup | ||
| ## | ||
| # Rails 4.x provides `#deep_dup`, but it aggressively `#dup`'s class names | ||
| # too. These model names should not be `#dup`'ed or we might break ActiveModel::Naming. |
There was a problem hiding this comment.
thanks for the comment, I get it now. Those aren't class names, technically, those are classes themselves, where dup'ing would make a new class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should backport these fixes to a 5.9.3 release.