Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated methods (deprecated by DocumentPresenter) into the new presenters #1431

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 6, 2016

This should fix more backwards compatibility breaks introduced in 6.3.

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.1%) to 77.01% when pulling 2ba70b9 on field_values into 908066f on master.

@cbeer cbeer changed the title Re-add deprecated DocumentPresenter#render_values until Blacklight 7.x Add deprecated methods (deprecated by DocumentPresenter) into the new presenters Jul 6, 2016
@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.09%) to 76.979% when pulling 2d18de6 on field_values into 908066f on master.


describe 'deprecated methods' do
before do
allow(Deprecation).to receive(:warn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If their being deprecated is part of the point, shouldn't this be a before :each { expect ... }?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to care; I wasn't setting out to test if deprecation was working, just to keep it quiet.

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.09%) to 76.979% when pulling 73afcb4 on field_values into 908066f on master.

@coveralls
Copy link

coveralls commented Jul 7, 2016

Coverage Status

Coverage increased (+0.1%) to 76.991% when pulling e4981ad on field_values into 908066f on master.

@coveralls
Copy link

coveralls commented Jul 7, 2016

Coverage Status

Coverage increased (+0.1%) to 77.002% when pulling 5bcf0df on field_values into bd81c15 on master.

@jcoyne jcoyne merged commit e26f407 into master Jul 7, 2016
@cbeer cbeer deleted the field_values branch July 7, 2016 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants