-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecated methods (deprecated by DocumentPresenter) into the new presenters #1431
Conversation
|
||
describe 'deprecated methods' do | ||
before do | ||
allow(Deprecation).to receive(:warn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If their being deprecated is part of the point, shouldn't this be a before :each { expect ... }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to care; I wasn't setting out to test if deprecation
was working, just to keep it quiet.
This should fix more backwards compatibility breaks introduced in 6.3.