-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5 backports #1545
V5 backports #1545
Conversation
When Turbolinks is not being used, the variable will be undefined and you will get a `ReferenceError: Turbolinks is not defined`.
@@ -13,7 +13,7 @@ Blacklight = function() { | |||
|
|||
listeners: function () { | |||
var listeners = []; | |||
if (Turbolinks && Turbolinks.supported) { | |||
if (typeof Turbolinks !== 'undefined' && Turbolinks.supported) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Turbolinks' is not defined.
Looks like you'll need the engine_cart upgrade too. |
@@ -31,6 +31,6 @@ Gem::Specification.new do |s| | |||
s.add_development_dependency "rspec-collection_matchers", ">= 1.0" | |||
s.add_development_dependency "capybara" | |||
s.add_development_dependency "poltergeist" | |||
s.add_development_dependency 'engine_cart', '~> 0.8.0' | |||
s.add_development_dependency 'engine_cart', '~> 0.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~> 1.0
?
2 similar comments
I'd be ok with dropping the rails 4.0 build. The alternative, I guess, is to try to pin the devise dependency for that build. |
No description provided.