Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main to v8.0.0.alpha, dropping deprecated behaviors #2458

Merged
merged 97 commits into from
Nov 16, 2021

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented May 5, 2021

This is mostly a rebase of #2393 with updates to get it current, but dropped a couple commits that we might want to visit some day:

  • 5065c03 (super conflict-y and needs to be redone)
  • dbcdfd2 (possibly not needed)

Beyond dropping deprecated methods and behavior from v7, this PR also:

  • bumps the minimum view_component version and removes some of the blacklight-custom shims to maintain backwards compatibility with older view component APIs
  • drops support for Rails 5.2 (which.. may not be a strict requirement, but Rails 5.2 and 7.x will probably be incompatible)
  • drops some of the default actions configuration that must be explicitly configured in the local application (generated by default for quite some time)

@cbeer cbeer moved this from Backlog to Needs Major Version in Blacklight Summit Triage Board Nov 9, 2021
@tpendragon
Copy link
Member

@cbeer CI is failing, how can I most effectively help make this happen? Should we just put on the committer call an agenda item for making Blacklight 8 the main branch?

@cbeer
Copy link
Member Author

cbeer commented Nov 12, 2021

I've rebased this and it's close to passing. Those commits that needed review or reworking still need some attention, and needs some work to get the pile of ugly commits at the end re-integrated into the earlier commits where appropriate.

This PR also requires #2516 to get merged first first, in order to fix up some behavior that is deprecated and is removed in this PR.

@cbeer cbeer force-pushed the v8-deprecations-take-2 branch 5 times, most recently from 21018f4 to 8052876 Compare November 16, 2021 15:34
@cbeer cbeer marked this pull request as ready for review November 16, 2021 15:58
@cbeer cbeer changed the title Get ready for v8.0.0 Update main to v8.0.0.alpha, dropping deprecated behaviors Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants