Use and prefer view config components by default over the default view config partials

[cbeer]

Now that we're enabling and configuring view components enabled by default, we can stop configuring partials by default. Partial configuration is still available and will append the rendered content to the document.

[dkinzer]

I've been playing around with upgrading one of our instances to latest changes and it fails with that, but with this branch I'm able to upgrade without issues.

[cbeer]

Hm. I wouldn't expect that #2458 would have changed anything. Can you provide more detail about what the issue was? I do think the repurposed partial configuration here will make migration easier (but are difficult to make backwards compatible), so maybe that's it?

[dkinzer]

@cbeer the error I getting at fd33c74

is

NoMethodError in Catalog#show

Showing /Users/dkinzer/projects/funnel_cake/app/views/catalog/_show.html.erb where line #1 raised:

undefined method `show_presenter' for #<#<Class:0x00007fa748452a58>:0x00007fa748405af0>

Extracted source (around line #1):

1 2 3 4 5 6	<% doc_presenter = show_presenter(document) %> <%# default partial to display solr document fields in catalog show view -%>

Which happens when I try to look at a document. If I switch to this branch the issue is resolved.

[dkinzer]

Also, we are overriding that template that is failing with this

<% doc_presenter = show_presenter(document) %>


<%# default partial to display solr document fields in catalog show view -%>
<div class="row">
  <div class="col-12">
    <dl class="row dl-invert document-metadata">
      <% doc_presenter.fields_to_render.each do |field_name, field| -%>
        <dt class="blacklight-<%= field_name.parameterize %> col-md-3"><%= render_document_show_field_label document, field: field_name %></dt>
        <dd class="align-self-center blacklight-<%= field_name.parameterize %> col-md-9"><%= doc_presenter.field_value field %></dd>
      <% end -%>
    </dl>
  </div>
  <div class="col-12">
    <dl class="row dl-invert document-metadata">
      <dt class="align-self-center col-md-3"><%= staff_view_link(document.id) %></dt>
    </dl>
  </div>
</div>

[jcoyne]

@dkinzer show_presenter was removed from the 8.x (main) branch. It was deprecated https://github.com/projectblacklight/blacklight/blob/release-7.x/app/helpers/blacklight/blacklight_helper_behavior.rb#L338