Convert search history display to use components #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
search-history-components
branch
from
d8c5d0f
to
daf8252
Compare
cbeer
force-pushed
the
search-history-components
branch
2 times, most recently
from
2c27bd2
to
81a5884
Compare
cbeer
force-pushed
the
search-history-components
branch
from
81a5884
to
86d1399
Compare
cbeer
changed the title
jcoyne
requested changes
Feb 18, 2022
…ring constraints the same general approach used on the search page
cbeer
force-pushed
the
search-history-components
branch
from
86d1399
to
63d22d5
Compare
jcoyne
approved these changes
Feb 18, 2022
tpendragon
approved these changes
Feb 21, 2022
jcoyne
added a commit
that referenced
this pull request
Feb 28, 2022
Backport #2626: Extract components for displaying previous searches as text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require backporting to 7.x with a nice deprecation warning for the
Blacklight::SearchHistoryConstraintsHelperBehaviormethods.This PR does change the way the search history is displayed. Currently, facets are grouped by their field:
This PR displays them more like the way constraints are display elsewhere in the application:
Part of getting bounding box info (from
params[:bbox]) displaying on the search history page without overriding helpers: geoblacklight/geoblacklight#1163