Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against bootstrap variable not being defined #2638

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Guard against bootstrap variable not being defined #2638

merged 1 commit into from
Mar 16, 2022

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Feb 25, 2022

fixes #2612

  • Bootstrap 5.x always creates window.bootstrap.
  • Bootstrap 4.x creates window.bootstrap if the application loads bootstrap
  • Bootstrap 4.x injects its classes directly on the window if the application loads bootstrap-sprockets

jcoyne added a commit that referenced this pull request Feb 25, 2022
@jcoyne
Merge pull request #2639 from projectblacklight/backport-2638
0488bdb 
Backport #2638: Guard against bootstrap variable not being defined; fixes #2612
@bess bess merged commit a4131f8 into main Mar 16, 2022
@bess bess deleted the 2612-bootstrap-variable branch March 16, 2022 19:28
@jrochkind jrochkind mentioned this pull request Apr 21, 2022
Closed
@cjcolvar cjcolvar mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bess bess bess approved these changes

@jcoyne jcoyne jcoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Blacklight 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7.22.0 broke Javascript for me: Uncaught ReferenceError: bootstrap is not defined
3 participants
@cbeer @bess @jcoyne