Explicitly test that bootstrap and bootstrap.Modal are defined #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to upgrade my blacklight-based app to 7.x from the latest 6.x and ran into an issue where the
more >>facet modal failed to open due tobootstrapnot being defined. Prior tickets and conversation seemed to point to includingbootstrapin my sprockets asset pipeline instead ofbootstrap-sprockets, but I was already only using thebootstrapinclude. Adding an explicit check for'undefined'worked for me, but I'm unsure if there is a better way to solve this or if by doing this it is breaking the bootstrap 5+ scenario.I ran the rollup script to compile the changes to
blacklight.jssince that is what my application was pulling in via sprockets. I can remove these changes toblacklight.jsif it is supposed to be handled in a different process.Previous work: