-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract a base component for blacklight #2690
Conversation
18cba2e
to
2c2408b
Compare
Since we've made a decision on This allows simple overrides of component templates that exist in the engine by placing them in the same place in the installing application. If a file in the installing application doesn't have a same-named analog in the engine, it won't be recognized - this has an impact on translation sidecars if the installing app is more expansive than the engine in language scope. But the Compiler interface is more stable, and if |
|
||
module Blacklight | ||
class Component < ViewComponent::Base | ||
class << self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation around what this is doing and why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentary comments added.
…he installing app - this permits overriding existing sidecar files, but not the addition of new files (e.g. translations)
edf4f86
to
8f043d8
Compare
Backports #2679 to 7.x