Compile javascript for jsbundling-rails tests #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
changed the title
jcoyne
added a commit
to cbeer/engine_cart
that referenced
this pull request
Dec 14, 2022
The former is broader and may include precompiling javascript if using jsbundling-rails. See projectblacklight/blacklight#2942
This is needed for the jsbunding-rails support (Propshaft build) now that 1.1.0 is out. This change rails/jsbundling-rails#128 means the build is no longer triggered on db:test:prepare
corylown
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the jsbunding-rails support (Propshaft build) now that 1.1.0 is out. This change rails/jsbundling-rails#128 means the build is no longer triggered on
rake db:test:prepare