Enhance spec:prepare command with JS build #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
added a commit
to projectblacklight/blacklight
that referenced
this pull request
Dec 14, 2022
This is needed for the jsbunding-rails support (Propshaft build) now that 1.1.0 is out. This change rails/jsbundling-rails#128 means the build is no longer triggered on db:test:prepare
jcoyne
added a commit
to projectblacklight/blacklight
that referenced
this pull request
Dec 14, 2022
This is needed for the jsbunding-rails support (Propshaft build) now that 1.1.0 is out. This change rails/jsbundling-rails#128 means the build is no longer triggered on db:test:prepare
jcoyne
added a commit
to projectblacklight/blacklight
that referenced
this pull request
Dec 14, 2022
This is needed for the jsbunding-rails support (Propshaft build) now that 1.1.0 is out. This change rails/jsbundling-rails#128 means the build is no longer triggered on db:test:prepare
rmehner
added a commit
to rmehner/tailwindcss-rails
that referenced
this pull request
Jun 20, 2023
jsbundling-rails (rails/jsbundling-rails#128) and cssbundling-rails (rails/cssbundling-rails#116) do the same and it's useful for people who are using RSpec.
smartech7
pushed a commit
to smartech7/rails-tailwind-css
that referenced
this pull request
Aug 4, 2023
jsbundling-rails (rails/jsbundling-rails#128) and cssbundling-rails (rails/cssbundling-rails#116) do the same and it's useful for people who are using RSpec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects using RSpec, the
javascript:buildtask isn't appended to the test preparation task, since RSpec uses aspecnamespace. To avoid having to call the enhance method in the project Rakefile, I think it would make sense to have it in here.