Construct index, show and facet field labels from the field name if no field name is available. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| end | ||
|
|
||
| ## | ||
| # Look up the label for the show field | ||
| def document_show_field_label document, field | ||
| label = document_show_fields(document)[field].label | ||
|
|
||
| field_config document_show_fields(document)[field] |
There was a problem hiding this comment.
is this missing an assignment = operator?
cbeer
force-pushed
the
possible-bad-facet-name-fix
branch
from
0786651
to
1997445
Compare
…o field name is available.
cbeer
force-pushed
the
possible-bad-facet-name-fix
branch
from
1997445
to
503bfdb
Compare
jcoyne
added a commit
that referenced
this pull request
Nov 10, 2014
…e-fix Construct index, show and facet field labels from the field name if no field name is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the problems in #974