Bump libcalico go #1814
Merged
Bump libcalico go #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
New icmp validation is more strict. This commit updates dummy rules so they pass validation.
ozdanborne
force-pushed
the
bump-libcalico-go
branch
from
b04fa29
to
46bed62
Compare
| @@ -260,7 +258,6 @@ | |||
| ], | |||
| 'ingress': [ | |||
| { | |||
| 'notICMP': {'type': 19, 'code': 255}, | |||
There was a problem hiding this comment.
Why are we removing these? Which part of validation does this fail?
There was a problem hiding this comment.
There's a proto: TCP just below.
There was a problem hiding this comment.
These rules have both ICMP rules and Ports rules, which is invalid now:
- If includes port rules, protocol needs to be TCP.
- If it includes ICMP rules, protocol needs to be ICMP
caseydavenport
approved these changes
Mar 1, 2018
|
@ozdanborne could you write a release note? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Release Note