Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per IP rate limit? #6411

Closed
sabershahhoseini opened this issue May 6, 2024 · 4 comments
Closed

Per IP rate limit? #6411

sabershahhoseini opened this issue May 6, 2024 · 4 comments
Labels
kind/question Categorizes an issue as a user question. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sabershahhoseini
Copy link

Is there any way to apply per IP rate limit? Seems like local rate limits do not care about IP and only thing is they care is how many requests are given to upstream service.

I mean, if someone just bulk requests to my service, anyone else gets 429? It's not good!

@sabershahhoseini sabershahhoseini added kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Hey @sabershahhoseini! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@sunjayBhatia
Copy link
Member

Is there any way to apply per IP rate limit? Seems like local rate limits do not care about IP and only thing is they care is how many requests are given to upstream service.

Envoy's local rate limit filter does not offer more advanced mechanisms for filtering requests or applying different requests based on source IP

this can be achieved using global rate limiting and using the request source IP in a descriptor that the rate limit server applies a specialized rate limit for, see: https://projectcontour.io/docs/1.28/config/rate-limiting/#global-rate-limiting

@sunjayBhatia sunjayBhatia removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label May 6, 2024
Copy link

github-actions bot commented Jul 8, 2024

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2024
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Categorizes an issue as a user question. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants