Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix custom port check #713

Closed
wants to merge 2 commits into from
Closed

Bugfix custom port check #713

wants to merge 2 commits into from

Conversation

JoshuaMart
Copy link
Contributor

I tested locally and my change seems to solve the problem, I tested via the following commands :

 echo "example.com" | ./httpx -ports 443
 echo "example.com" | ./httpx -ports 442-443
 echo "example.com" | ./httpx -ports https:443
 echo "example.com" | ./httpx -ports http:80,https:443

@ehsandeep ehsandeep linked an issue Jul 28, 2022 that may be closed by this pull request
Mzack9999 added a commit that referenced this pull request Jul 31, 2022
@Mzack9999 Mzack9999 added the Status: On Hold Similar to blocked, but is assigned to someone label Jul 31, 2022
ehsandeep pushed a commit that referenced this pull request Jul 31, 2022
* Fixing and improving custom ports

* adding test case from #713
@ehsandeep
Copy link
Member

@JoshuaMart thanks for the PR, this is now fixed in #714 with some additional improvements.

@ehsandeep ehsandeep closed this Jul 31, 2022
@ehsandeep ehsandeep removed the Status: On Hold Similar to blocked, but is assigned to someone label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants