Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No graceful shutdown i.e. no way to stop naabu from scanning except killing the process #698

Closed
a-urth opened this issue Jun 2, 2023 · 0 comments · Fixed by #946
Closed
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@a-urth
Copy link

a-urth commented Jun 2, 2023

Naabu version:

v2, using as library

Current Behavior:

Naabu upon call to RunEnumeration spawns bunch of workers to perform scanning in background and blocks until it finishes. Using it as a library with other operations running in background (like processing any other form of input) there is no way to stop it except killing process which it running in.

Expected Behavior:

There should blocking method Stop in case naabu is running concurrently with other goroutines which will gracefully stop all workers.

@a-urth a-urth added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 2, 2023
@Mzack9999 Mzack9999 linked a pull request Jan 30, 2024 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 4, 2024
@ehsandeep ehsandeep added this to the naabu v2.3.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants