Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): Ensure proper scanning strategy #3464

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

nHurD
Copy link
Contributor

@nHurD nHurD commented Mar 23, 2023

Proposed changes

This will ensure that the host spray scanning strategy will actually run rather than the system exiting quickly if that strategy is applied. Once merged, this will resolve #3463.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

This will ensure that the host spray scanning strategy will actually
run rather than the system exiting quickly if that strategy is
applied. Once merged, this will resolve projectdiscovery#3463.
@nHurD nHurD marked this pull request as ready for review March 23, 2023 13:53
@ehsandeep ehsandeep linked an issue Mar 23, 2023 that may be closed by this pull request
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @nHurD , looks like there was typo/missed it in hurry

@ehsandeep ehsandeep merged commit 710ac08 into projectdiscovery:dev Mar 23, 2023
@nHurD nHurD deleted the fix-scanning-strategy branch March 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect checking of scanning strategy
3 participants