Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tls version enum internally when using -cipher-enum flag #164

Closed
noraj opened this issue Jan 22, 2023 · 6 comments · Fixed by #168
Closed

enable tls version enum internally when using -cipher-enum flag #164

noraj opened this issue Jan 22, 2023 · 6 comments · Fixed by #168
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@noraj
Copy link
Contributor

noraj commented Jan 22, 2023

tlsx version:

v1.0.4

Current Behavior:

$ tlsx -u example.org -cipher-enum
...                                                                                                                                                                                
example.org:443                                                                                                                                                                                                      
[INF] Connections made using crypto/tls: 1, zcrypto/tls: 0, openssl: 0

$ tlsx -u example.org -cipher-enum -sm openssl
...
example.org:443

$ tlsx -u example.org -cipher-enum -sm openssl -cipher
...
example.org:443 []

$ tlsx -u example.org -cipher-enum -sm ztls
...
example.org:443

$ tlsx -u example.org -cipher-enum -sm ctls
...
example.org:443

Expected Behavior:

enumerate and display supported cipher

Steps To Reproduce:

cf. current behavior

Anything else:

Same behavior whatever the host is. Version enumeration is working.

@noraj noraj added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 22, 2023
@tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Jan 22, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Jan 24, 2023
@tarunKoyalwar
Copy link
Member

tarunKoyalwar commented Jan 24, 2023

@noraj -cipher-enum requires -version-enum since cipher enumeration is done based on tls version .
currently if cipher-enum is not done if -version-enum flag is missing .

I guess cipher-enum should internally do version-enum without explicitly passing the flag

@noraj
Copy link
Contributor Author

noraj commented Jan 24, 2023

Sure, I thought I tested with both too.

@tarunKoyalwar
Copy link
Member

@noraj , you should be able to use it in next release . there was minor issue in #163 and others which will be resolved shortly

@tarunKoyalwar tarunKoyalwar changed the title cipher enumeration not working enable tls version enum internally when using -cipher-enum flag Jan 24, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Jan 24, 2023 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jan 25, 2023
@ehsandeep ehsandeep added this to the tlsx v1.0.5 milestone Jan 25, 2023
@noraj
Copy link
Contributor Author

noraj commented Jan 28, 2023

@noraj -cipher-enum requires -version-enum since cipher enumeration is done based on tls version . currently if cipher-enum is not done if -version-enum flag is missing .

I guess cipher-enum should internally do version-enum without explicitly passing the flag

I was going to say even when you use both flag you see nothing:

$ tlsx -u pwn.by -cipher-enum -version-enum     
  

  _____ _    _____  __
 |_   _| |  / __\ \/ /
   | | | |__\__ \>  < 
   |_| |____|___/_/\_\  v1.0.4

                projectdiscovery.io

pwn.by:443 [tls13,tls12]
[INF] Connections made using crypto/tls: 34, zcrypto/tls: 3, openssl: 341

Because originally I was using both flag but I see in #168 it was outputting only on JSON output and not on STDOUT. So this should be good for 1.0.5.

@ehsandeep
Copy link
Member

@noraj should be fixed now with the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants