Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGR incorrect default alphas in RidgeRegression #260

Closed
eric-czech opened this issue Jul 23, 2020 · 2 comments
Closed

WGR incorrect default alphas in RidgeRegression #260

eric-czech opened this issue Jul 23, 2020 · 2 comments
Assignees

Comments

@eric-czech
Copy link

In the second stage regression for WGR, the default alphas generated here based on the number of distinct headers are including the label values:

self.alphas = generate_alphas(blockdf)

This means that the alphas become a function of the number of outcomes (i.e. labels), which I assume isn't what was intended right? It seems odd to me that the results would change for one outcome if it was fit alone vs w/ others, so I think it should probably only be based on the number of features for the regression like stage 1 -- number of variant blocks * number of stage 1 alphas (not then also * number of outcomes).

@eric-czech eric-czech changed the title WGR incorrect default alphas in RidgeRegressor WGR incorrect default alphas in RidgeRegression Jul 23, 2020
@LelandBarnard
Copy link
Contributor

Hi Eric, great catch, I only recently noticed this as well It is definitely unintended, we will fix it in an upcoming release.

@henrydavidge
Copy link
Contributor

This is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants