This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Select node version #306
Merged
Select node version #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +24,9 @@ public class CustomBuilder : ISiteBuilder | |||
| private const string PreviousManifestPath = "PREVIOUS_MANIFEST_PATH"; | |||
| private const string NextManifestPath = "NEXT_MANIFEST_PATH"; | |||
| private const string MSBuildPath = "MSBUILD_PATH"; | |||
| private const string KuduSyncCommandKey = "KUDU_SYNC_COMMAND"; | |||
There was a problem hiding this comment.
Would be nice to avoid duplicating all these tokens for each mode. Maybe make them internal in one of them and get them there from the other.
There was a problem hiding this comment.
Although there are still some duplication, in the long run the intention is to remove the old deployment logic and with it all this duplication.
added 5 commits
January 16, 2013 16:41
…deployment and update selectNodeVersion.js script.
…t scenario. Fixed issue #274.
…e it's not going to use the version selection for npm. Instead updated selectNodeVersion.js script to have backwards compatibility (temp dir is optional).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues: #305 and #254.
Moved node version selection from the node deployment logic in kudu service to the deployment script generator (when generating a node deployment script).
This way:
Number 2 is only for the new generator deployment logic and not for the original one, since we will switch this sprint (or the next) and until then users can use the custom script if they require this support.