-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify BSD+MIT+Go+UPL+ISC license mentions in NOTICE
file + expose in Nessie server, GC-tool, Admin-Tool and CLI/REPL
#8498
Conversation
97de015
to
c65acfc
Compare
@@ -33,3 +33,15 @@ dependencies { | |||
} | |||
|
|||
tasks.withType<Test>().configureEach { useJUnitPlatform() } | |||
|
|||
tasks.register("compileAll").configure { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these two tasks here as well, as a convenience
@@ -219,3 +222,17 @@ class MemoizedGitInfo { | |||
} | |||
} | |||
} | |||
|
|||
afterEvaluate { | |||
tasks.register("codeChecks").configure { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convenience task to run "all the code checks"
@@ -51,6 +51,7 @@ dependencies { | |||
implementation(project(":nessie-rest-common")) | |||
implementation(project(":nessie-rest-services")) | |||
implementation(project(":nessie-versioned-spi")) | |||
implementation(project(":nessie-notice")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all what's needed to make curl http://127.0.0.1:19120/NOTICE.txt
work
NOTICE
file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE
file + expose it in Nessie server, GC-tool and CLI/REPL tools
NOTICE
file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE
file + expose it in Nessie server, GC-tool and CLI/REPL tools
NOTICE
file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE
file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL tools
NOTICE
file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL toolsNOTICE
file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL
NOTICE
file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPLNOTICE
file + expose in Nessie server, GC-tool, Admin-Tool and CLI/REPL
mod.poms.flatMap { it.licenses }.map { it.name }) | ||
.distinct() | ||
|
||
if (!licenses.any { needsNoNotice(it) } && licenses.any { needsNotice(it) }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is meant for dual licensing, maybe add a comment explaining the rationale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - it's for (most) dependencies that use more than one license.
* Update dependency com.github.jk1:gradle-license-report to v2.8 * Fix left-over from #8498 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robert Stupp <snazy@snazy.de>
Dependencies that are not Apache licensed but MIT/BSD/Go/UPL/ISC licensed must include an entry in the
NOTICE
file. This change verifies that an "entry" for those dependencies is present.This change also allows "retrieving" the
NOTICE
via:/NOTICE.txt
from Nessie/Quarkus serverHELP LICENSE
in the CLI/REPLshow-licenses
command in the GC toolAlso:
codeChecks
task, that includes license-checks, spotless-check and checkstyle.NOTICE
file