Verify BSD+MIT+Go+UPL+ISC license mentions in NOTICE file + expose in Nessie server, GC-tool, Admin-Tool and CLI/REPL
#8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
notice-file-checks
branch
3 times, most recently
from
97de015
to
c65acfc
Compare
snazy
commented
May 11, 2024
| @@ -33,3 +33,15 @@ dependencies { | |||
| } | |||
|
|
|||
| tasks.withType<Test>().configureEach { useJUnitPlatform() } | |||
|
|
|||
| tasks.register("compileAll").configure { | |||
There was a problem hiding this comment.
Adding these two tasks here as well, as a convenience
| @@ -219,3 +222,17 @@ class MemoizedGitInfo { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| afterEvaluate { | |||
| tasks.register("codeChecks").configure { | |||
There was a problem hiding this comment.
Convenience task to run "all the code checks"
| @@ -51,6 +51,7 @@ dependencies { | |||
| implementation(project(":nessie-rest-common")) | |||
| implementation(project(":nessie-rest-services")) | |||
| implementation(project(":nessie-versioned-spi")) | |||
| implementation(project(":nessie-notice")) | |||
There was a problem hiding this comment.
That's all what's needed to make curl http://127.0.0.1:19120/NOTICE.txt work
snazy
changed the title
NOTICE file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE file + expose it in Nessie server, GC-tool and CLI/REPL tools
snazy
changed the title
NOTICE file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE file + expose it in Nessie server, GC-tool and CLI/REPL tools
snazy
changed the title
NOTICE file + expose it in Nessie server, GC-tool and CLI/REPL toolsNOTICE file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL tools
snazy
changed the title
NOTICE file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL toolsNOTICE file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPL
snazy
changed the title
NOTICE file + expose it in Nessie server, GC-tool, Admin-Tool and CLI/REPLNOTICE file + expose in Nessie server, GC-tool, Admin-Tool and CLI/REPL
adutra
approved these changes
May 11, 2024
| mod.poms.flatMap { it.licenses }.map { it.name }) | ||
| .distinct() | ||
|
|
||
| if (!licenses.any { needsNoNotice(it) } && licenses.any { needsNotice(it) }) { |
There was a problem hiding this comment.
I suppose this is meant for dual licensing, maybe add a comment explaining the rationale?
There was a problem hiding this comment.
Correct - it's for (most) dependencies that use more than one license.
snazy
added a commit
that referenced
this pull request
May 27, 2024
renovate bot
added a commit
that referenced
this pull request
May 27, 2024
* Update dependency com.github.jk1:gradle-license-report to v2.8 * Fix left-over from #8498 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robert Stupp <snazy@snazy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies that are not Apache licensed but MIT/BSD/Go/UPL/ISC licensed must include an entry in the
NOTICEfile. This change verifies that an "entry" for those dependencies is present.This change also allows "retrieving" the
NOTICEvia:/NOTICE.txtfrom Nessie/Quarkus serverHELP LICENSEin the CLI/REPLshow-licensescommand in the GC toolAlso:
codeCheckstask, that includes license-checks, spotless-check and checkstyle.NOTICEfile