Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Decouple riff doctor command from knowledge of the cluster internals #13

Closed
scothis opened this issue Jun 19, 2019 · 2 comments
Closed

Comments

@scothis
Copy link
Member

scothis commented Jun 19, 2019

The riff doctor command gives users the ability to perform basic checks on the health of the cluster and whether riff is ready for use. We should not bake intimate knowledge of the system runtime into the CLI.

For example, the command currently looks for the knative-build namespace. Knative Build is an implementation detail that is likely to change in the near future.

We have a few options:

  1. live with the tight coupling
  2. reduce the scope of riff doctor to only focus on user land concerns
  3. create a generic configuration that lives in the cluster that the doctor command can process
@scothis scothis transferred this issue from projectriff/riff Jun 20, 2019
@fbiville
Copy link
Contributor

Do you have specific ideas with option #2?
It seems to me it's hard to diagnose if something works without looking "under the hood".

@scothis
Copy link
Member Author

scothis commented Aug 15, 2019

Done in #61

@scothis scothis closed this as completed Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants