This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
Consume new riff system #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples us from github.com/knative/pkg, with the exception of two source files copied into the project, which are only used for testing. As we migrate away from static clients we can remove those added files.
|
Depends on projectriff/system#105 |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 96.15% 95.48% -0.67%
==========================================
Files 80 80
Lines 4524 4521 -3
==========================================
- Hits 4350 4317 -33
- Misses 150 181 +31
+ Partials 24 23 -1
Continue to review full report at Codecov.
|
sbawaska
reviewed
Oct 3, 2019
cmd/riff/main.go
Outdated
| @@ -22,7 +22,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| // load credential helpers | |||
| _ "k8s.io/client-go/plugin/pkg/client/auth" | |||
| _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" | |||
There was a problem hiding this comment.
simplifying the dependency graph, I'll put it back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples us from github.com/knative/pkg, with the exception of two
source files copied into the project, which are only used for testing.
As we migrate away from static clients we can remove those added files.