Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Generate static clientset #105

Merged
merged 8 commits into from
Oct 3, 2019
Merged

Generate static clientset #105

merged 8 commits into from
Oct 3, 2019

Conversation

scothis
Copy link
Member

@scothis scothis commented Oct 3, 2019

This is the shim to aid in migrating the CLI to the current system. It
will likely be removed in the future.

@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@91b4eaf). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #105   +/-   ##
========================================
  Coverage          ?   2.02%           
========================================
  Files             ?      45           
  Lines             ?    2810           
  Branches          ?       0           
========================================
  Hits              ?      57           
  Misses            ?    2753           
  Partials          ?       0
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/zz_generated.deepcopy.go 0% <ø> (ø)
pkg/apis/knative/v1alpha1/zz_generated.deepcopy.go 0% <ø> (ø)
pkg/controllers/streaming/processor_controller.go 0% <ø> (ø)
pkg/apis/build/v1alpha1/application_types.go 25% <0%> (ø)
pkg/apis/streaming/v1alpha1/kafkaprovider_types.go 33.33% <0%> (ø)
pkg/apis/core/v1alpha1/deployer_types.go 33.33% <0%> (ø)
pkg/apis/streaming/v1alpha1/stream_types.go 25% <0%> (ø)
pkg/apis/build/v1alpha1/container_types.go 25% <0%> (ø)
pkg/apis/streaming/v1alpha1/processor_types.go 33.33% <0%> (ø)
pkg/apis/knative/v1alpha1/adapter_types.go 33.33% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b4eaf...5c7abec. Read the comment docs.

The groupName tag needs to live in doc.go for code-generator

```
// +groupName=core.projectriff.io
```
Copy link
Member

@sbawaska sbawaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scothis scothis merged commit 6643ca2 into projectriff:master Oct 3, 2019
@scothis scothis deleted the client-gen branch October 3, 2019 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants