Upgrade ArgoCD to 1.8

[megian]

Because of an bug/feature the component nginx-ingress couldn't be installed correctly. It does require ArgoCD 1.8. See argoproj/argo-cd#2737 for more details.

I've created the branch upgrade-1.8 and in in-place upgrade with ArgoCD itself did work, except of sync the repo-server deployment.

The sync did stop with the error:
The Deployment "argocd-repo-server" is invalid: spec.template.spec.containers[0].livenessProbe.tcpSocket: Forbidden: may not specify more than 1 handler type

To proceed I did command to replace the entire object:
k -n syn replace -f ~/Git/syn/commodore/catalog/manifests/argocd/30_repo-server/deployment.yaml

This worked out and ArgoCD 1.8.3 is currently working. And also the deployment of the application-controller gets removed. See https://argoproj.github.io/argo-cd/operator-manual/upgrading/1.7-1.8/#the-argocd-application-controller-converted-to-statefulset as reference.

Neverless steward expects to have deployments and not a statefulset and is continuously creating a deployment:
I0203 17:32:04.755780 1 app-controller.go:103] Created Argo CD application-controller deployment

Issues to fix:

• Check if there is an way to replace the repo-server deployment rather than apply
• Fix steward not creating an no longer required deployment Steward incompatible to ArgoCD 1.8 steward#61

[megian]

Fix steward not creating an no longer required deployment projectsyn/steward#61 has been fixed.

[megian]

Similar issue kubernetes/kubernetes#30991

[megian]

readinessProbe.tcpSocket is replaced by readinessProbe.httpGet

     --- manifests/argocd/30_repo-server/deployment.yaml
     +++ manifests/argocd/30_repo-server/deployment.yaml
     @@ -16,6 +16,21 @@
            labels:
              app.kubernetes.io/name: argocd-repo-server
          spec:
            automountServiceAccountToken: false
            containers:
                name: argocd-repo-server
                readinessProbe:
     +            httpGet:
     +              path: /healthz
     +              port: 8084
                  initialDelaySeconds: 5
                  periodSeconds: 10
     -            tcpSocket:
     -              port: 8081
                volumeMounts:
                  - mountPath: /app/config/ssh
                    name: ssh-known-hosts

[megian]

Simplest workaround is to remove the liveness probe of argocd-repo-server:

oc patch deployment/argocd-repo-server -n syn --type json -p '[{"op":"remove", "path": "/spec/template/spec/containers/0/livenessProbe"}]'

[tobru]

Should we upgrade this issue to say "Upgrade Argo CD to 2.0"?

[megian]

Should we upgrade this issue to say "Upgrade Argo CD to 2.0"?

No I'm closing this. This is relevant information for the upgrade to 1.8. The upgrade 1.8 to 2.0 is different and this has no relation to https://argoproj.github.io/argo-cd/operator-manual/upgrading/1.8-2.0/.