Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring different image registries #20

Open
simu opened this issue Sep 14, 2021 · 3 comments
Open

Support configuring different image registries #20

simu opened this issue Sep 14, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Sep 14, 2021

Context

Currently, the component doesn't allow customizing the image registries for the container images used by the component. Being able to configure a different registry can be useful in cases where a registry mirror is required (e.g. to avoid dockerhub pull rate limits).

Alternatives

Deal with intermittent pods in ImagePullBackOff due to pull rate limits.

@simu simu added the enhancement New feature or request label Sep 14, 2021
@megian
Copy link
Contributor

megian commented Sep 15, 2021

Relates to cloudscale-ch/csi-cloudscale#31.

@megian
Copy link
Contributor

megian commented Dec 9, 2022

@simu Can we close this issue if favor of #53, where the registry can be overridden?

@simu
Copy link
Member Author

simu commented Dec 9, 2022

not really, since the component best practices recommend having separate parameters for the Helm chart and container images (cf. https://syn.tools/syn/explanations/commodore-components/container-images.html and https://syn.tools/syn/explanations/commodore-components/helm-charts.html). To ensure we get a single PR which updates both the Helm chart and the container image, we can configure Renovate to group the updates, cf. https://github.com/projectsyn/component-rook-ceph/blob/1a5be5e0a4bbd72659c546ac39eb83d19a284474/renovate.json#L18-L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants