Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in css-fetching #97

Closed
bartveneman opened this issue Jun 16, 2021 · 8 comments · Fixed by #100
Closed

Remove built-in css-fetching #97

bartveneman opened this issue Jun 16, 2021 · 8 comments · Fixed by #100
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@bartveneman
Copy link
Member

The headless CSS fetching mechanism requires a whole lot of dependencies and install time. I think it should be separated so that it would would be two different steps, using get-css or someone just piping a local file into wallace-cli:

get-css https://www.projectwallace.com > wallace
@bartveneman bartveneman added help wanted Extra attention is needed question Further information is requested labels Jun 16, 2021
@drewlustro
Copy link

Yes please.

Not to mention that puppeteer is a nightmare dependency to keep functional with all architectures, platforms, etc.

@drewlustro
Copy link

Need help with this one?

I'm adopting wallace-cli at my org as an experiment. I'd be willing to give this issue a shot, provided wallace works out for us.

@bartveneman
Copy link
Member Author

Should be pretty straightforward, so feel free to pick up, but maybe I'll have some time this weekend to have a look.

This was referenced May 19, 2022
Merged
@bartveneman
Copy link
Member Author

@drewlustro I have a WIP branch that's very lightweight and fast, without Puppeteer that you could try out using npx https://github.com/projectwallace/wallace-cli\#v3 path/to/style.css

@drewlustro
Copy link

@bartveneman – Thanks mate.

I'm headed to Detroit for a music festival tonight, but will take a look next Thursday.

@mryechkin
Copy link

@drewlustro I have a WIP branch that's very lightweight and fast, without Puppeteer that you could try out using npx https://github.com/projectwallace/wallace-cli\#v3 path/to/style.css

Does this work for anyone else? I just tried running and nothing happens:
Screenshot 2023-09-06 at 1 17 29 PM

@bartveneman
Copy link
Member Author

I had to push some untested local changes because I got a new computer a while back, so its very well possible this branch is currently broken. I completely forgot about it.

Did you hit enter when it asked you to proceed though?

@mryechkin
Copy link

Did you hit enter when it asked you to proceed though?

Yes, nothing happened - just returned me to the terminal.

I was able to build the v3 branch locally and use it that way, and it worked great - but obviously that's a temporary solution. Hopefully that PR can get merged at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Development

Successfully merging a pull request may close this issue.

3 participants