-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: SVG logo for table Investment Dashboard #30
Comments
TradingView uses the same kind of UI & they support extensive list of companies. Just to get unblocked we can use this s3 link for now and get something our own down the line.
if you agree, I can raise a PR @meglerhagen |
Sounds like i plan, would like it to be in the same colors as the rest. But we can take it down the road. @akkikumar72, just raise a PR and lets start with that. for the classname we should have it simlar to the other table. This is what i used before Know that we can edits svgs online, so we can proable make them the same color as the rest if we look 👋 |
I also got this @akkikumar72 for icons (Tip from twitter) - https://simpleicons.org/ |
#32 |
Lets close this issue |
Title
See link for the tweet: https://twitter.com/pJacquelDesign/status/1742834610533253604
Thank you https://twitter.com/pJacquelDesign for the feedback ✨
Improvement Description
Could it be possible to have to logos of the company for faster visual recognition? :)
Proposed Solution
Make logo conditional render based on what Company is in the data list (source code)
Alternatives (optional)
Here is somewhere you can make SVGs:
Like this fee API: https://clearbit.com/logo
Or word vector logos : https://worldvectorlogo.com
The text was updated successfully, but these errors were encountered: