Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

.metadata.json for AoT #44

Closed
metaory opened this issue Nov 30, 2016 · 4 comments
Closed

.metadata.json for AoT #44

metaory opened this issue Nov 30, 2016 · 4 comments

Comments

@metaory
Copy link

metaory commented Nov 30, 2016

Third party libs have to be AoT-ed before they can be integrated in an AoT compiled application. The third party library should publish JS files, .d.ts files and metadata.json files

Getting your Angular 2 library ready for AoT

AoT compile err

@metaory
Copy link
Author

metaory commented Nov 30, 2016

Managed to generate the .metadata.json from this repo gulp :build:components:ngc
why these .metadata.json files not included in packaged release?

that solved the missing .metadata.json files,

these properties should be public as well,
Property 'top' is private and only accessible within class 'Md2TooltipComponent'.
Property 'left' is private and only accessible within class 'Md2TooltipComponent'.
Property '_isVisible' is private and only accessible within class 'Md2TooltipComponent'.

this is gonna work.
will make a pr soon

@metaory
Copy link
Author

metaory commented Nov 30, 2016

there is another problem with MouseEvent now, will look at this later

MouseEvent is not defined

@metaory
Copy link
Author

metaory commented Dec 5, 2016

thanks @dharmeshpipariya for 66c03f6
this fixed the .metadata.json issue for AoT build,

I had to make almost all privates to public, for AoT build, not sure how badly that would pollute the global namespace, but that's what AoT build wants!

the Universal build however is failing terribly all over the place, and its mainly pending
angular/components#308

I'll just close this issue

@metaory metaory closed this as completed Dec 5, 2016
@dharmeshpipariya-zz
Copy link
Contributor

We have fixed this issue with release md2@0.0.10-3,
comment here if you have an issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants