[kube-prometheus-stack] fixes thanos ruler object store configs #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thameezb
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: ThameezBo <thameezbo@double.cloud>
thameezb
force-pushed
the
fix/kube-prometheus-stack-thanos-ruler-objectstore-configs
branch
from
8fd7d25
to
b48ee42
Compare
charts/kube-prometheus-stack/templates/thanos-ruler/secret.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: thameezb <thameezbo@double.cloud>
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: thameezb <thameezbo@double.cloud>
GMartinez-Sisti
approved these changes
Oct 18, 2023
|
Thanks @thameezb !! |
|
Hi @GMartinez-Sisti @thameezb , this PR is totally breaking, same as #3870 This code both worked for people (including me) alertmanagersConfig:
name: thanos-monitoring-config
key: alertmanagers.yml
objectStorageConfig:
name: thanos-monitoring-config
key: objstore.yml
queryConfig:
name: thanos-monitoring-config
key: query.ymlto point Thanos Ruler to my own existing secret. These PRs break this behavior. I think initially that was a misunderstanding of what should be placed in values for people who created this issue. I don't want to place sensitive data inside of values and I already have Thanos deployed via bitnami chart which utilize exact same secret in almost same way. Can you please revert back changes done in this PRs or add sort of: |
|
Oh no! Thanks for letting us know @dragoangel. Let me see if we can easily fix it forward as you suggested, or we’ll revert it. |
Thank you for your quick reply |
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 20, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | patch | `51.9.1` -> `51.9.4` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v51.9.4`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.4) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Update CoreDNS Dashboard. Add job template variable by [@​StianOvrevage](https://github.com/StianOvrevage) in prometheus-community/helm-charts#3798 #### New Contributors - [@​StianOvrevage](https://github.com/StianOvrevage) made their first contribution in prometheus-community/helm-charts#3798 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4 ### [`v51.9.3`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.3) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Fix etcd dashboards by [@​QuentinBisson](https://github.com/QuentinBisson) in prometheus-community/helm-charts#3917 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3 ### [`v51.9.2`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.2) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fixes thanos ruler object store configs by [@​thameezb](https://github.com/thameezb) in prometheus-community/helm-charts#3913 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/160 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Closed
1 task
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Mar 20, 2024
…etheus-community#3913) * fix: kube-prom-stack thanos-ruler objectstoreConfigs Signed-off-by: ThameezBo <thameezbo@double.cloud> * Update charts/kube-prometheus-stack/templates/thanos-ruler/ruler.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: thameezb <thameezbo@double.cloud> * Update charts/kube-prometheus-stack/templates/thanos-ruler/secret.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: thameezb <thameezbo@double.cloud> --------- Signed-off-by: ThameezBo <thameezbo@double.cloud> Signed-off-by: thameezb <thameezbo@double.cloud> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes ThanosRuler objectstore configs
Which issue this PR fixes
fixes #3912
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])