Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Fix etcd dashboards #3917

Merged

Conversation

QuentinBisson
Copy link
Member

@QuentinBisson QuentinBisson commented Oct 18, 2023

What this PR does / why we need it

This PR regenerates the etcd dashboard as the mixins were fixed as a result of discussions from #3880 (comment)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson
Copy link
Member Author

QuentinBisson commented Oct 18, 2023

@GMartinez-Sisti could you look at this one? It's basically applying the following upstream fix etcd-io/etcd#16778

@GMartinez-Sisti GMartinez-Sisti merged commit 2da4141 into prometheus-community:main Oct 18, 2023
4 checks passed
@QuentinBisson
Copy link
Member Author

Thank you :)

@jkroepke
Copy link
Member

Thanks!

nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 20, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | patch | `51.9.1` -> `51.9.4` |

---

### Release Notes

<details>
<summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary>

### [`v51.9.4`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.4)

[Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4)

kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator.

#### What's Changed

-   \[kube-prometheus-stack] Update CoreDNS Dashboard. Add job template variable by [@&#8203;StianOvrevage](https://github.com/StianOvrevage) in prometheus-community/helm-charts#3798

#### New Contributors

-   [@&#8203;StianOvrevage](https://github.com/StianOvrevage) made their first contribution in prometheus-community/helm-charts#3798

**Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4

### [`v51.9.3`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.3)

[Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3)

kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator.

#### What's Changed

-   \[kube-prometheus-stack] Fix etcd dashboards by [@&#8203;QuentinBisson](https://github.com/QuentinBisson) in prometheus-community/helm-charts#3917

**Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3

### [`v51.9.2`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.2)

[Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2)

kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator.

#### What's Changed

-   \[kube-prometheus-stack] fixes thanos ruler object store configs by [@&#8203;thameezb](https://github.com/thameezb) in prometheus-community/helm-charts#3913

**Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/160
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Matiasmct pushed a commit to giffgaff/prometheus-charts that referenced this pull request Mar 20, 2024
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kube-prometheus-stack] Grafana dashboard for etcd broken
3 participants