-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement deletion based on partially matching labels #1013
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
34486f9
WIP partial match
stone-z b8653c0
Cleanup
stone-z 0820be3
Comments
stone-z 387c4f0
Tests and comments
stone-z fa775cf
Handle properly deleting multiple metrics, update tests
stone-z 9a8cb32
Comments
stone-z 7e947b6
Try using curry values
stone-z e79ef55
Skip curry value to demo
stone-z 5514642
Fix curry deletion, remove outdated comment.
stone-z e56280b
Fix logic for deletion of metrics from prior to currying
stone-z 27d7f47
Don't match curried values. Update tests.
stone-z 89fe389
Remove unneccesasry helper and todo comments
stone-z 6533de3
Comment about partial matching curried labels
stone-z 8168be3
Simplify curried value check
stone-z File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the computational complexity of this function? I imagine it is
O(metrics count)
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I hoped to find a constant time implementation but didn't find one (at least at the time)