Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposition format: How to deal with duplicate metric families #547

Open
beorn7 opened this issue Sep 9, 2016 · 1 comment
Open

exposition format: How to deal with duplicate metric families #547

beorn7 opened this issue Sep 9, 2016 · 1 comment

Comments

@beorn7
Copy link
Member

beorn7 commented Sep 9, 2016

The current spec is crystal clear that duplicate metric families (and, correspondingly, multiple TYPE and HELP lines for the same metric name in the text format) are not allowed in a single exposition.

However, the federation endopint of the prometheus server is currently in breach of that, see. prometheus/prometheus#1963 .

This issue is about whether we should allow duplicate metric families, and if yes, how to deal with them.
(Problematic right now is that the Prometheus server tolerates them if ingesting protobuf, and just ingests them one after another, while it rejects any text format exposition with multiple TYPE or HELP lines for the same metric name.)

@beorn7
Copy link
Member Author

beorn7 commented Feb 13, 2017

To clarify: prometheus/prometheus#1963 is fixed, so federation output is not in breach of the spec anymore.

aylei pushed a commit to aylei/docs that referenced this issue Oct 28, 2019
* op-guide: add notes about @@

* Update wording

* Update wording

* Update wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant