-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete reference to closed issue #198
Conversation
@@ -184,9 +184,8 @@ sampling timestamp, no interpolated sample is generated for this time series at | |||
this point in time. This effectively means that time series "disappear" from | |||
graphs at times where their latest collected sample is 5 older than 5 minutes. | |||
|
|||
NOTE: <b>NOTE:</b> Staleness and interpolation handling might change. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around line 177 is no longer true, could you update that too?
prometheus/prometheus#581 also relates to interpolation |
a5e0722
to
67de90c
Compare
Well, I opted to simply link that issue instead, since that's possibly relevant. Thanks for the link! (first attempt was
It's not actually obvious to me how/why line 177 is no longer true. Could you clarify? |
This is no longer the behaviour, we now take the newest sample before the timestamp. |
67de90c
to
f0bd055
Compare
Aha, ok (just saw the issue discussing the change). I updated the text, could you review it? |
Remove obsolete reference to closed issue
Thanks! |
* Create json-functions-generated-column.md * Update json-functions-generated-column.md
As far as I understand it, the interpolation handling (at least in a way relevant to the linked issue) did not and will not change as a result of that issue.
I could be wrong.