Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete reference to closed issue #198

Merged
merged 1 commit into from
Aug 31, 2015

Conversation

ChaoticMind
Copy link
Contributor

As far as I understand it, the interpolation handling (at least in a way relevant to the linked issue) did not and will not change as a result of that issue.

I could be wrong.

@@ -184,9 +184,8 @@ sampling timestamp, no interpolated sample is generated for this time series at
this point in time. This effectively means that time series "disappear" from
graphs at times where their latest collected sample is 5 older than 5 minutes.

NOTE: <b>NOTE:</b> Staleness and interpolation handling might change. See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Around line 177 is no longer true, could you update that too?

@brian-brazil
Copy link
Contributor

prometheus/prometheus#581 also relates to interpolation

@ChaoticMind
Copy link
Contributor Author

Well, I opted to simply link that issue instead, since that's possibly relevant. Thanks for the link! (first attempt was a5e0722)

Around line 177 is no longer true, could you update that too?

It's not actually obvious to me how/why line 177 is no longer true. Could you clarify?

@brian-brazil
Copy link
Contributor

Prometheus searches for the closest surrounding samples and
linearly interpolates a timestamp-value pair between the actual stored samples.

This is no longer the behaviour, we now take the newest sample before the timestamp.

@ChaoticMind
Copy link
Contributor Author

Aha, ok (just saw the issue discussing the change). I updated the text, could you review it?

brian-brazil added a commit that referenced this pull request Aug 31, 2015
Remove obsolete reference to closed issue
@brian-brazil brian-brazil merged commit 669720e into prometheus:master Aug 31, 2015
@brian-brazil
Copy link
Contributor

Thanks!

aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
* Create json-functions-generated-column.md

* Update json-functions-generated-column.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants