Add SNMPInflight metric #1119
Merged
Add SNMPInflight metric #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kakuya Ando <fservak@gmail.com>
SuperQ
requested changes
Feb 20, 2024
Signed-off-by: Kakuya Ando <fservak@gmail.com>
SuperQ
approved these changes
Feb 20, 2024
SuperQ
reviewed
Feb 20, 2024
main.go
Outdated
| prometheus.GaugeOpts{ | ||
| Namespace: namespace, | ||
| Name: "request_in_flight", | ||
| Help: "Current number of requests being served.", |
There was a problem hiding this comment.
Suggested change
| Help: "Current number of requests being served.", | |
| Help: "Current number of SNMP scrapes being requested.", |
Signed-off-by: Kakuya Ando <fservak@gmail.com>
RobertBergman
pushed a commit
to RobertBergman/snmp_exporter
that referenced
this pull request
Feb 26, 2024
* Add SNMPInflight metric --------- Signed-off-by: Kakuya Ando <fservak@gmail.com> Signed-off-by: Robert Bergman <rob.bergman@gmail.com>
SuperQ
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Add SNMPInflight metric (#1119) * Add SNMPInflight metric --------- Signed-off-by: Kakuya Ando <fservak@gmail.com> Signed-off-by: Robert Bergman <rob.bergman@gmail.com> * change #1074 broke SNMPv3 by removing the lines that need to go in config.go after 155 and 171 respectively: usm.AuthenticationPassphrase = string(c.Password) and usm.PrivacyPassphrase = string(c.PrivPassword) after adding the back in to the code, I tried running with having variables set via environment and in the snmp.yml and both worked. without them I was getting the error: securityParameter.PrivacyPassphrase is required when a privacy protocol is specified Signed-off-by: Robert Bergman <rob.bergman@gmail.com> --------- Signed-off-by: Kakuya Ando <fservak@gmail.com> Signed-off-by: Robert Bergman <rob.bergman@gmail.com> Co-authored-by: Kakuya Ando <fservak@gmail.com>
Merged
SuperQ
pushed a commit
that referenced
this pull request
May 11, 2024
* [CHANGE] Improve generator parse error handling #1167 * [ENHANCEMENT] generator: Add generator HELP override #1106 * [ENHANCEMENT] Refactoring of Scrape process, fixing multiple module issues #1111 * [ENHANCEMENT] Skip using an interactive terminal in "make docker-generate". #1113 * [ENHANCEMENT] Add SNMPInflight metric #1119 * [FEATURE] Support for passing username, password & priv_password as env vars #1074 * [FEATURE] Add GoSNMP logger #1157 * [FEATURE] Add a "snmp_context" parameter to the URL #1163 * [BUGFIX] generator: curl failed #1094 * [BUGFIX] Fix SNMPv3 password configuration #1122 * [BUGFIX] generator: Update generator User-Agent #1133 * [BUGFIX] generator: fix mibs directory specification for parse_errors command #1135 * [BUGFIX] generator: remove extra character from dell iDrac-SMIv1 MIB #1141 * [BUGFIX] Fix do not expand envvars for empty config fields #1148 snmp.yml changes: * Updated Cisco MIBs #1180 * Updated Cyberpower MIBs #1124 * Updated servertech_sentry3 #1090 * Added support for Dell iDrac #1125 --------- Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an implementation to export the current number of requests.