Add a "snmp_context" parameter to the URL #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
|
tested the change with my arista, does whats expected and does not break scraping of snmpv1/v2 |
This was referenced May 3, 2024
Closed
Merged
SuperQ
pushed a commit
that referenced
this pull request
May 11, 2024
* [CHANGE] Improve generator parse error handling #1167 * [ENHANCEMENT] generator: Add generator HELP override #1106 * [ENHANCEMENT] Refactoring of Scrape process, fixing multiple module issues #1111 * [ENHANCEMENT] Skip using an interactive terminal in "make docker-generate". #1113 * [ENHANCEMENT] Add SNMPInflight metric #1119 * [FEATURE] Support for passing username, password & priv_password as env vars #1074 * [FEATURE] Add GoSNMP logger #1157 * [FEATURE] Add a "snmp_context" parameter to the URL #1163 * [BUGFIX] generator: curl failed #1094 * [BUGFIX] Fix SNMPv3 password configuration #1122 * [BUGFIX] generator: Update generator User-Agent #1133 * [BUGFIX] generator: fix mibs directory specification for parse_errors command #1135 * [BUGFIX] generator: remove extra character from dell iDrac-SMIv1 MIB #1141 * [BUGFIX] Fix do not expand envvars for empty config fields #1148 snmp.yml changes: * Updated Cisco MIBs #1180 * Updated Cyberpower MIBs #1124 * Updated servertech_sentry3 #1090 * Added support for Dell iDrac #1125 --------- Signed-off-by: Sebastian Schubert <basti@schubert.digital>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
snmp_contextparameter to the URL, e.g.:Fixes #1040
This is essentially the same PR as #845.
I have not tested this yet. What do you think would be a good way to test? For now I'll try to set something up with snmpsim. Also, I'm not sure if I need to add any unit tests?
@SuperQ @RichiH