fix(parse_errors command): fix mibs directory specification for parse_errors command #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyfellows
force-pushed
the
enable-m-flag-for-parse_errors
branch
from
07fe6df
to
7de3de7
Compare
…y Fellows <kennyfellows@gmail.com> Signed-off-by: Kenneth Fellows <kennyfellows@gmail.com>
kennyfellows
force-pushed
the
enable-m-flag-for-parse_errors
branch
from
7de3de7
to
435283f
Compare
SuperQ
approved these changes
Mar 14, 2024
Merged
SuperQ
pushed a commit
that referenced
this pull request
May 11, 2024
* [CHANGE] Improve generator parse error handling #1167 * [ENHANCEMENT] generator: Add generator HELP override #1106 * [ENHANCEMENT] Refactoring of Scrape process, fixing multiple module issues #1111 * [ENHANCEMENT] Skip using an interactive terminal in "make docker-generate". #1113 * [ENHANCEMENT] Add SNMPInflight metric #1119 * [FEATURE] Support for passing username, password & priv_password as env vars #1074 * [FEATURE] Add GoSNMP logger #1157 * [FEATURE] Add a "snmp_context" parameter to the URL #1163 * [BUGFIX] generator: curl failed #1094 * [BUGFIX] Fix SNMPv3 password configuration #1122 * [BUGFIX] generator: Update generator User-Agent #1133 * [BUGFIX] generator: fix mibs directory specification for parse_errors command #1135 * [BUGFIX] generator: remove extra character from dell iDrac-SMIv1 MIB #1141 * [BUGFIX] Fix do not expand envvars for empty config fields #1148 snmp.yml changes: * Updated Cisco MIBs #1180 * Updated Cyberpower MIBs #1124 * Updated servertech_sentry3 #1090 * Added support for Dell iDrac #1125 --------- Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SuperQ, this PR fixes an issue where the
parse_errorscommand was not finding the./mibsdirectory, therefore preventing theparse_errorscommand from working properly. This fix also adds support for manually specifying the mibs directory via the-mflag in theparse_errorscommand.Context
Previously, the
parse_errorscommand was not correctly finding the defaultmibsdirectory, nor did it allow the user to manually specify a mibs directory.The
make generate(orgenerator generateafter building) works by defaulting to the sibling./mibsdirectory, butmake parse_errors(orgenerator parse_errors) does not. The reason for this, is because the command line parser will interpret an omitted flag as an empty string. So this line, when running thegeneratecommand, is evaluating to a length of1with an empty string, therefore defaulting to theC.netsnmp_get_mib_directory(). But since this flag wasn't enable for theparse_errorscommand, that same line was evaluating to a length of0, and no default was being returned.