Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should support sampling for timer metrics #57

Closed
majewsky opened this issue Jan 6, 2017 · 1 comment
Closed

should support sampling for timer metrics #57

majewsky opened this issue Jan 6, 2017 · 1 comment

Comments

@majewsky
Copy link

majewsky commented Jan 6, 2017

I'm sending statsd metrics from Openstack Swift to the statsd_exporter and seeing error messages like:

time="2017-01-06T10:18:08Z" level=error msg="Illegal sampling factor for non-counter metric on line swift.object-server.REPLICATE.timing:0.654935836792|ms|@0.1" source="exporter.go:390"

The statsd_exporter only allows sampling factors for counter metrics, but it should also do so for timer metrics. See for example https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing for upstream documentation that references sampling factors for timer metrics.

@majewsky
Copy link
Author

This was apparently fixed in b5dfc9c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant