-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect IBM/HCL Notes Client for Domino Support #667
Comments
I think I misunderstood Notes with Node.js when @JustinProminic mentioned about this in Getting Started page, which completed as #661 in branch. |
Are we need two separate entries or one, in Getting Started page?
We can accommodate same pattern usability that we triggers for macOS Git/SVN access, where user prompts and requires to browse-select particular folder to provide bookmarking access. |
- No download link condition (reference Moonshine-IDE/Moonshine-IDE#667)
- Added initial codes for Getting Started check (reference #667)
- Adding detection in SDK-installer (reference Moonshine-IDE/Moonshine-IDE#667)
- Permission window to provide access on macOS - Some older codes adjusted (reference #667)
Codes adjusted and tested both on Windows and macOS. While on Windows it suppose to detect by following two default locations:
On macOS, this suppose to test following two locations:
On macOS, a permission access will be ask through Getting Started window, as we have permission request for Git/SVN on macOS. |
I tested this from a branch build. Some minor text updates - I may request further changes after reviewing with @JustinProminic: Update the Getting Started By Feature entry to:
Update the "Notes Domino" settings page:
I get this prompt when clicking the configure icon on the Getting Started path for both the App Store and non-Sandbox builds. This is not needed for non-Sandbox, since we don't need a bookmark to acess the directory. Change the text to:
@rat-moonshine and I also discussed some behavior issues with the file chooser. The behavior changes with the Finder view mode that is selected by the user: Only the third view mode (from the second screenshot) enables the Open button. The other views show the contents of IBM Notes.app, and there is no .app file to select (see the first screenshot). We need to make sure that this will work for all four view modes. We may need to experiment with a custom filter using FileFilter. |
While using FileFilter (to select .app file only) didn't made any difference for me in testing. |
Getting Started window doesn't appear on startup when IBM/HCL Notes is detected, but access is not granted. I'll discuss with @JustinProminic whether this is desired - not all users will want this. The text on the Allow Access prompt was not update: In the AppStore version, the FileChooser opens to whichever directory was last accessed, rather than to /Applications/IBM Notes.app. If we can't avoid this, then the FileFilter logic discussed above may not matter, since the user would need to manually browse to IBM Notes.app anyway. The Allow Access prompt no longer appears on the non-Sandbox build, but I still see the warning icon on the Getting Started page: |
- Removed some unnecessary codes (reference #667)
- Notes size updated for Notes in configuration (reference Moonshine-IDE/Moonshine-IDE#667)
I'm not sure if I successfully able to test this case - as Getting Started opens for me if an item has pending download and 'do not show again' checkbox is not selected, during my tests.
Texts have updated.
Showing of warning now adjusted. Please, check. |
We need to avoid using the trademark name IBM anymore. Only HCL should be used. And it should be like this: HCL (R) Notes / Domino. Don't make it say in pop-up boxes and configuration screens IBM / HCL. Just use HCL only. |
Besides the change from @JustinProminic's comment above, the updates looked good in my test. |
IBM references now removed from Moonshine and Moonshine-SDK-Installer. |
Beside I tested that the path I'm providing to the ANE to open-by the file chooser in sandbox Moonshine, which was correct; I also read through this article which were discussing similar type of problem if not exact: So I went through some more tests to understand the pre-selection behaviour better on sandbox. Following were my findings during these tests.
After these I have a feeling that Apple reinforced a mix kind of restrictions, maybe. When I'm not sure if this a limitation/restriction regulated by Apple, if or how we can do something about it. |
In order for the user to do a DXL Import (#668) or On Disk Project (#646, #669) without entering their Notes password, they need to update a setting in the Notes client. I'd like to provide some guidance for the users when they set up the Notes path. For now, I'd like to add a writeup like this to the Domino Settings page. If it doesn't fit well within the page, you can have it open with a link like "Enable passwordless access."
If the user does not include this setting, they'll see the script hang with a password prompt (and in some cases, the prompt might be buried in other text). I'll look into how we can make the operations fail in a clearer way. If we can detect the problems automatically, we can display a message like this:
|
Above instruction added into Domino settings view. |
This issue is now merged into 'master'. |
If that issue involves update to Installer please send me link for newest version. I'm closing issue. |
Branch for Moonshine SDK Installer also merged into 'master'. So you should access the functionality with new usual build. |
Ahh!! Sorry I forgot that we have now automatic build of Installer ;) Thanks! |
In order to use Domino tools like DXL Importer (#668) or On Disk Project (#669, #670, #646), the user needs to have the Notes client installed at a location where Moonshine can access it.
This is similar to the checks we do for SDKs with Getting Started. Nowever, we can't automate the install of IBM/HCL Notes on a workstation, so we just want to find and save the path.
The expected directories are:
The App Store build won't be able to access these directories without a bookmark, so we will need a settings page where they can can select the path. This should be in the other builds as well, but we expect it to be populated by default.
I'll give the details for how to use this path in the related issues above.
Some other checks we may need to do:
The text was updated successfully, but these errors were encountered: