Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pull request for deviation before writing comments #39

Closed
mmozuras opened this issue Oct 22, 2014 · 4 comments
Closed

Check pull request for deviation before writing comments #39

mmozuras opened this issue Oct 22, 2014 · 4 comments
Assignees
Labels

Comments

@mmozuras
Copy link
Member

GithubPullRequestFormatter bug:

If new commits are added to a pull request, Pronto sometimes writes comments on incorrect lines. Before doing that, it should check whether pull request hasn't changed.

Reported by @ljank

@mmozuras mmozuras added the bug label Oct 22, 2014
@mmozuras mmozuras self-assigned this Oct 22, 2014
@Linuus
Copy link

Linuus commented Dec 15, 2014

@mmozuras Was this fixed? I seem to get this issue sometimes. I run the master version from github.

@mmozuras
Copy link
Member Author

mmozuras commented Jan 9, 2015

@Linuus I considered it fixed, but it was reproduced in another way today. Reopening again and will try to figure it out.

@mmozuras mmozuras reopened this Jan 9, 2015
@somebody32
Copy link

Got the same issue today. But pronto messes positions even without pr changes at all, just comments on the wrong lines.

Fixed by changing line.position to message.line.position https://github.com/mmozuras/pronto/blob/master/lib/pronto/formatter/github_pull_request_formatter.rb#L21

but don't think that this is a proper fix

@mmozuras
Copy link
Member Author

PRs from @jhass fix this. Currently unreleased in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants