chore(console): multiple scopes with fix for app deletion #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolsar42
changed the title
poolsar42
force-pushed
the
fix/2360-console-toast-when-delete-app-dialog
branch
from
63bb0a9
to
539d4df
Compare
betimshahini
requested changes
Jun 7, 2023
| @@ -467,7 +467,7 @@ export default function AppDetailIndexPage() { | |||
| experimental: value.experimental, | |||
| } | |||
| })} | |||
| selectedItems={appDetails.app.scopes?.map((scope) => { | |||
| preselectedItems={appDetails.app.scopes?.map((scope) => { | |||
There was a problem hiding this comment.
Type-checker doesn't like this.
| disabled?: boolean | ||
| onChange?: () => void | ||
| learnMore?: string | ||
| } | ||
|
|
||
| const ComboboxItem = ({ item, selected }) => { |
There was a problem hiding this comment.
Depending on the width of field at the point the page is rendered, different issues arise. In general, the size of the dropdown contorl and the pills contained within, don't adjust relative to the surroundings.
- When starting on regular desktop width, and decreasing the width of the window we see the field width doesn't resize as other input fields do.
- When going into mobile view, the whole viewport remains stretched relative to the fixed size of the dropdown input field.
- When refreshing page on a narrow desktop view, or mobile view, we see scope pills overlapping with the chevron of the dropdown control itself
There was a problem hiding this comment.
Thank you for detailed review. I didn't think properly of resizing the window size during one session
For this reason I've added ResizeObserver to constantly scan the size of this dropdown and properly adjust panels.
There was a problem hiding this comment.
poolsar42
force-pushed
the
fix/2360-console-toast-when-delete-app-dialog
branch
from
539d4df
to
fbd4bf2
Compare
betimshahini
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies list of allowed scopes to display it properly when there're too many selected
And also It doesn't save app detail in auth page in console when opening delete app dialog
Related Issues
Testing
Locally in console and with storybook
Checklist